Add Support for Laravel 11 and drop Support for Laravel 8, 9, 10 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the package to support Laravel 11.
Laravel 11 will require
symfony/console:^7.0, which had a breaking change in theSignalableCommandInterface@handleSignalmethod signature.For easier maintenance, I've removed support for Laravel 8, 9 and 10 and PHP versions below 8.2.
I honestly have no clue what value
handleSignalshould return. I've opted to return the$signalin this PR, but please double check if this is the correct behaviour.(While upgrading other packages to support Laravel 11 I noticed that this package doesn't support it either, so I thought I just send in a PR)